Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Fix data-testid prop spelling #1153

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[no-Jira] Fix data-testid prop spelling #1153

merged 1 commit into from
Oct 23, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 23, 2024

Description

Fix the data-testid prop to avoid React does not recognize the data-testId prop on a DOM element warnings in DevTools.

FYI @caleballdrin

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz October 23, 2024 17:43
@canac canac self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 5ade3d4

No significant changes found

@canac canac merged commit 559211c into main Oct 23, 2024
17 checks passed
@canac canac deleted the test-id-warning branch October 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz